Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nokia Tones are not supported yet #40

Closed
AShiningRay opened this issue Nov 18, 2024 · 4 comments
Closed

Nokia Tones are not supported yet #40

AShiningRay opened this issue Nov 18, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@AShiningRay
Copy link
Collaborator

This is just a note for later. Nokia OTT/OTA tones aren't implemented at all. I reckon it should follow the current implementations for Siemens MelodyComposer and Sprintpcs + Bell DualTone, by converting the incoming byte array into midi (using the Square Wave instrument)... this would make it so every single tone implementation uses the main audio handler, PlatformPlayer, as a base, dodging most of the code duplication that would have to happen, and helping maintenance quite a bit.

@AShiningRay AShiningRay added the bug Something isn't working label Nov 18, 2024
@AShiningRay AShiningRay self-assigned this Nov 18, 2024
@SergioFLS
Copy link

SergioFLS commented Nov 19, 2024

For reference, this document somewhat describes the format: https://affon.narod.ru/GSM/ssm200.pdf (see 3.8 Ringing Tones)

There's also a parser in AOSP's sonivox: https://github.com/pedrolcl/sonivox/blob/290e469a8fd4871413e4c544f7820650c36bc056/arm-wt-22k/lib_src/eas_ota.c

@AShiningRay
Copy link
Collaborator Author

AShiningRay commented Nov 20, 2024

For reference, this document somewhat describes the format: https://affon.narod.ru/GSM/ssm200.pdf (see 3.8 Ringing Tones)

There's also a parser in AOSP's sonivox: https://github.com/pedrolcl/sonivox/blob/290e469a8fd4871413e4c544f7820650c36bc056/arm-wt-22k/lib_src/eas_ota.c

Yep, those have come to my attention a while ago, and i've actually come across a newer revision of that Smart Messaging Specification that also contains a ringing tone decode example as well, which can be found here, at section 5.1.5

I just need to find some time to focus exclusively on this.

@TwoSpacesSG
Copy link

MIDI playback using Nokia Sound (seen in Micro Machines for Nokia 176x208 for example) doesn't seem to be implemented either.

@AShiningRay
Copy link
Collaborator Author

Fixed by 5ee1044, 5946959, 6eb05b8 and 8fed7eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants