Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors #156

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Errors #156

merged 3 commits into from
Jan 20, 2025

Conversation

noisekit
Copy link
Contributor

Update error handling to include all the new contracts

@noisekit noisekit requested a review from peiman3 January 20, 2025 03:28
@noisekit noisekit self-assigned this Jan 20, 2025
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 4:20am

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 32.30769% with 44 lines in your changes missing coverage. Please review.

Project coverage is 65.64%. Comparing base (4d7b454) to head (6e37c43).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...idity/lib/parseContractError/parseContractError.ts 5.40% 35 Missing ⚠️
liquidity/lib/withERC7412/withERC7412.ts 64.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   65.59%   65.64%   +0.05%     
==========================================
  Files         263      265       +2     
  Lines        6484     6494      +10     
  Branches     2212     2210       -2     
==========================================
+ Hits         4253     4263      +10     
  Misses       2231     2231              
Files with missing lines Coverage Δ
...b/useContractErrorParser/useContractErrorParser.ts 80.00% <100.00%> (+24.44%) ⬆️
liquidity/lib/withERC7412/withERC7412.ts 62.01% <64.00%> (+7.69%) ⬆️
...idity/lib/parseContractError/parseContractError.ts 2.73% <5.40%> (-1.71%) ⬇️

... and 4 files with indirect coverage changes

@noisekit noisekit merged commit 083bc46 into master Jan 20, 2025
12 of 13 checks passed
@noisekit noisekit deleted the errors branch January 20, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant