Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

Slippage shown on Kwenta "Convert" page is different from what 1inch shows #328

Open
drptbl opened this issue Apr 12, 2021 · 1 comment
Open
Labels
bug Something isn't working convert Issue related to "Convert" feature

Comments

@drptbl
Copy link
Contributor

drptbl commented Apr 12, 2021

Description:
It seems that in some cases slippage is different on Kwenta comparing it to 1inch at the same time. I would expect them to be equal.

Prerequisites:

  • any synth in your wallet

Reproduction steps:

  1. Go to Kwenta "Convert" page (https://dev.kwenta.io/dashboard/convert)
  2. Connect your wallet
  3. Select any synth (for example "sXAU") inside "From" drop-down
  4. Click on your synth balance to fill maximum amount to swap
  5. Notice shown slippage inside "Into" input field
  6. Head over to 1inch and use the same pair to see the slippage and compare it to what you've seen on Kwenta

Current behavior:

  • slippage is different on Kwenta and 1inch

Expected behavior:

  • slippage should be equal on Kwenta and 1inch

Screenshots:
Below you can see that there was 1% difference in slippage between Kwenta and 1inch.
Screenshot_2021-04-09_at_00 14 33
Screenshot_2021-04-09_at_00 14 37

Desktop (please complete the following information):

  • OS: macOS Big Sur 11.2.2
  • Browser: Chrome 89.0.4389.95
@drptbl drptbl added bug Something isn't working convert Issue related to "Convert" feature labels Apr 12, 2021
@drptbl drptbl changed the title Slippage shown on Kwenta is different from what 1inch shows Slippage shown on Kwenta "Convert" page is different from what 1inch shows Apr 12, 2021
@evgenyboxer
Copy link
Contributor

evgenyboxer commented Apr 13, 2021

I'm not sure where they are pulling their price from... but I'm using coingecko, and I guess it's OK to have some difference

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working convert Issue related to "Convert" feature
Projects
None yet
Development

No branches or pull requests

2 participants