Ffmpeg update 4.2.1 #3778
Ffmpeg update 4.2.1 #3778
Conversation
th0ma7
force-pushed
the
ffmpeg-update-4.2
branch
from
bbe4ace to
b1e647a
Compare
|
Build and package upgrade successful. Also it does work properly with tvheadend. Current output: And available decoders (trucated): And supported devices (at least on my DS918+): |
|
From past experience with maintaining this package: There are patches in |
|
Thnx for the heads-up. |
|
Hello @th0ma7 Yet another challenge for you. |
|
I can certainly reach out to Synology but trying to figure out what the issue is to know what I am asking for.... Does it relate to this: Also is it a blocker to get this version out? Default syno And using latest build version 4.2.1: |
|
Ok, got answers from Synology. Both MediaServer and VideoStation has a copy of the Synology patched ffmpeg version 3.3.7 with only minor differences between them that can easily be merged together. The fun part: quick comparison of the code with the original source tree (
Most interesting, output patch doesn't apply as is over 4.2.1 but there isn't that many rejects... Worth investigating I guess. I'll see what i can do to create a patch file over 4.2.1. |
|
I was able to create a first patch without too much effort. Building is in progress, wait & see. |
|
Compiling & package building looking good. |
|
Temporary testing packages available here: Notes: Contains FFMPEG v4.2.1 + synology patch port but does not contain AV1 codec support yet. |
|
Having AV1 now working on supported arch. And the AV1 Packages updated with AV1 supported + synology patch |
cross/libaom/PLIST
Outdated
| rsc:lib/pkgconfig/aom.pc | ||
| rsc:include/aom/aom.h | ||
| rsc:include/aom/aom_codec.h | ||
| rsc:include/aom/aom_frame_buffer.h | ||
| rsc:include/aom/aom_image.h | ||
| rsc:include/aom/aom_integer.h | ||
| rsc:include/aom/aom.h | ||
| rsc:include/aom/aom_decoder.h | ||
| rsc:include/aom/aomdx.h | ||
| rsc:include/aom/aomcx.h | ||
| rsc:include/aom/aom_encoder.h |
There was a problem hiding this comment.
There is no need to include headers and pkgconfig files in generated package
There was a problem hiding this comment.
Indeed. I had found an issue in my earlier builds where pkgconfig file was creating errors but I guess that was due to the version mismatch at the time. I tried removing the headers & pkgconfig files from the PLIST and re-did a test build on selected arch successfully. Changes now committed.
Co-Authored-By: Yves Martin <[email protected]>
|
Hi @th0ma7 , I would test your ffmpeg package. But there seems no braswell package for my J3160. Which one should I download? |
|
|
|
thank you great work,but how this work in dsm 6.22? i use one patch change ffmpeg to this version ,but no luck with seck time.. |
|
Hopefuly I'm partially answering to your questions:
|
|
Hi,I’m use the ds918+,Dan 6.22.and I installed the ffmpeg 4.2package from your test repo, but it still can’t decode the dots audio ,so is it something I not doing right?
Sorry for my poor English,
From SLboat
… 在 2019年10月25日，05:09，Vincent Fortier ***@***.***> 写道：
Hopefuly I'm partially answering to your questions:
thank you great work,but how this work in dsm 6.22?
Is it compatible with DSM 6.2.2: yes
i use one patch change ffmpeg to this version ,but no luck with seck time..
patch? I'm sorry but I have no idea what you are referring to? git patches? pre-built packages?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I’m use j1900cpu, but installed ds918 system ,so should I use the x86 version instead apollolake version?
Here is what I have done:
1. Install the newest video station on dsm
2. Install the new ffmpeg from
https://github.com/th0ma7/synology/tree/master/packages
3. In video station open a dots video ,it still say can’t decode
Just like before
From SLboat
… 在 2019年10月25日，05:09，Vincent Fortier ***@***.***> 写道：
Hopefuly I'm partially answering to your questions:
thank you great work,but how this work in dsm 6.22?
Is it compatible with DSM 6.2.2: yes
i use one patch change ffmpeg to this version ,but no luck with seck time..
patch? I'm sorry but I have no idea what you are referring to? git patches? pre-built packages?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
DS918+ version has an apollolake processor. To me question is, are you able to decode it on the command line directly? |
|
I’m see now,I had see the issue,and use the script success play dts from beginning,but when I drag the time progress bar,it’s lack and cpu 100%
From SLboat
… 在 2019年10月25日，07:42，Vincent Fortier ***@***.***> 写道：
DS918+ version has an apollolake processor.
Therefore you can either use the x64 package or the arch specific apollolake package.
As for dots video, I guess you are referring to DTS ? If so I suggest you look at bug entry #2952 where some people might be able to help you out on this issue specifically.
To me question is, are you able to decode it on the command line directly?
Because the problem may be with ffmpeg or it's integration with videostation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
i think i know why we need this project now...the community ffmpeg is not as a fix for video staion, it's a package, fit for ffmpeg. |
sorry, i don't know how to use the command line to test ffmpeg, i think the dts decoder is work well, the problem is the video station. $ ffmpeg -codecs 2>/dev/null | grep -E 'ac3|dts'
..A.L. ac3 ATSC A/52A (AC-3)
D.A.L. atrac3 ATRAC3 (Adaptive TRansform Acoustic Coding 3)
D.A.L. atrac3p ATRAC3+ (Adaptive TRansform Acoustic Coding 3+) (decoders: atrac3plus )
..A.LS dts DCA (DTS Coherent Acoustics)
..A.L. eac3 ATSC A/52B (AC-3, E-AC-3)# /var/packages/VideoStation/target/bin/ffmpeg -codecs 2>/dev/null | grep -E 'ac3|dts'
D.A.L. ac3 ATSC A/52A (AC-3) (decoders: ac3 ac3_fixed )
D.A.L. atrac3 ATRAC3 (Adaptive TRansform Acoustic Coding 3)
D.A..S atrac3al ATRAC3 AL (Adaptive TRansform Acoustic Coding 3 Advanced Lossless)
D.A.L. atrac3p ATRAC3+ (Adaptive TRansform Acoustic Coding 3+) (decoders: atrac3plus )
D.A..S atrac3pal ATRAC3+ AL (Adaptive TRansform Acoustic Coding 3+ Advanced Lossless) (decoders: atrac3plusal )
..A.LS dts DCA (DTS Coherent Acoustics)
..A.L. eac3 ATSC A/52B (AC-3, E-AC-3)$ /usr/local/ffmpeg/bin/ffmpeg -codecs 2>/dev/null | grep -E 'ac3|dts'
DEA.L. ac3 ATSC A/52A (AC-3) (decoders: ac3 ac3_fixed ) (encoders: ac3 ac3_fixed )
D.A.L. atrac3 ATRAC3 (Adaptive TRansform Acoustic Coding 3)
D.A..S atrac3al ATRAC3 AL (Adaptive TRansform Acoustic Coding 3 Advanced Lossless)
D.A.L. atrac3p ATRAC3+ (Adaptive TRansform Acoustic Coding 3+) (decoders: atrac3plus )
D.A..S atrac3pal ATRAC3+ AL (Adaptive TRansform Acoustic Coding 3+ Advanced Lossless) (decoders: atrac3plusal )
DEA.LS dts DCA (DTS Coherent Acoustics) (decoders: dca ) (encoders: dca )
DEA.L. eac3 ATSC A/52B (AC-3, E-AC-3) |
|
I see, Thank you !
From SLboat
… 在 2019年10月25日，22:19，Vincent Fortier ***@***.***> 写道：
@SLboat please open-up a different issue for that problem specifically.
And again, have a look at issue #2952 which may be related somehow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
AppArmor fix added. |
Co-Authored-By: Yves Martin <[email protected]>
|
@th0ma7 In that situation, I prefer "squash and merge" to get a "cleaner" git history/log and normalize commit... Now it is done, do not try anything to fix. |
|
this build failed to decode some dts streams, following is a working build, any idea? |
Hi @kref , there are so many differences in the build you are referring to that there is sadly nowhere to start from. Please submit a new issue if you think there is something worth looking into and don't forget to provide details of your platform, DSM version, ffmpeg version and details, how you used it (natively or through "modified" videostation) along with a sample of the file that refuses to play. Thnx and goodluck! |
Hi @th0ma7 , further investigation suggests it is a GCC bug, rather than a configuration issue I suspected. |
Motivation: Update of FFMPEG from 4.1 to 4.2 with hope to resolve a few compatibility issues with VideoStation & MediaServer by porting Synology patches. Also AV1 codec is becoming more popular and can now be enabled.
PR Description
Checklist
all-supportedcompleted successfullyLinked issues: #2952, #3413 , #3688, #3716, #3751, #3759