fix(vue): vue created() does not check if mixin should run

SyneticNL · Aug 30, 2019 · 1c46520 · 1c46520
1 parent a57285f
commit 1c46520
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/packages/vue/__tests__/Mixin/Collection.test.js b/packages/vue/__tests__/Mixin/Collection.test.js
@@ -124,4 +124,23 @@ describe('The Collection mixin', () => {
 
     expect(mixin.$store.getters['hyral_product/collection']).not.toHaveBeenCalled();
   });
+
+  test('that the mixin doesn\'t initialize if the component does not define the collectionName or resourceType', () => {
+    const mixin = Object.assign({
+      initCollection: jest.fn(),
+      loadCollection: jest.fn(),
+    }, collectionMixin);
+
+    mixin.serverPrefetch();
+    expect(mixin.initCollection).not.toHaveBeenCalled();
+    expect(mixin.loadCollection).not.toHaveBeenCalled();
+
+    mixin.mounted();
+    expect(mixin.initCollection).not.toHaveBeenCalled();
+    expect(mixin.loadCollection).not.toHaveBeenCalled();
+
+    mixin.created();
+    expect(mixin.initCollection).not.toHaveBeenCalled();
+    expect(mixin.loadCollection).not.toHaveBeenCalled();
+  });
 });
diff --git a/packages/vue/src/Mixin/Collection.js b/packages/vue/src/Mixin/Collection.js
@@ -15,6 +15,10 @@ export default {
     },
   },
   created() {
+    if (!this.collectionName || !this.resourceType) {
+      return;
+    }
+
     this.initCollection();
   },
   /**