Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP 010 -- simplify description of sequence features and sub-parts #25

Closed
graik opened this issue Sep 21, 2016 · 6 comments
Closed

SEP 010 -- simplify description of sequence features and sub-parts #25

graik opened this issue Sep 21, 2016 · 6 comments

Comments

@graik
Copy link
Contributor

graik commented Sep 21, 2016

This proposal aims to clearly separate and simplify the description of part - subpart relations on the one hand, and the annotation of (genbank-style) sequence features on the other hand.

Proposal document: https://github.com/SynBioDex/SEPs/blob/master/sep_010.md

@graik
Copy link
Contributor Author

graik commented Sep 23, 2016

Updated after very productive discussion at COMBINE breakout session. The current formulation of the SEP prescribes changes for SBOL 2.2 (adding and deprecating fields) and for SBOL 3.0 (removing fields and renaming SequenceAnnotation to SequenceFeature.

@jakebeal jakebeal modified the milestones: SBOL 3.0, SBOL 2.2 Jan 12, 2017
@jakebeal
Copy link
Contributor

On discussion, the editors have determined that this is an SBOL 3.0 issue, because as soon as it is possible to write a file that does not have a SequenceAnnotation --> Component link, then it will not be possible for SBOL 2.0 or SBOL 2.1 tools to correctly interpret the location. This missing information means it is not a backward compatible change.

@NeilWipat
Copy link
Collaborator

Update from COMBINE 2018

Needs more discussion

@cjmyers cjmyers added Accepted and removed Draft labels Dec 11, 2019
@cjmyers
Copy link
Contributor

cjmyers commented Dec 11, 2019

This was already approved, but the remove of Component link from SA has not been executed yet or the adding or Location to Component. These were deferred to SBOL 3.

@bbartley
Copy link
Contributor

Once this SEP is implemented, can we relax the requirement that the definition property is required? I would like that property to be optional. For example, I would like to be able to represent sub-structure using only Components and their respective child Locations.

@cjmyers
Copy link
Contributor

cjmyers commented Dec 23, 2019

That would definitely need to be a different SEP. Not sure I'm excited about this idea. I guess it could allow you to avoid creating dummy CDs when constructing a design, which could be good. Not sure what the difference would be though in simply using SequenceAnnotations with Roles instead. I think that you end up in the same place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants