Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gregtech machines show as "unnamed.name" with no image in Xnet controllers #877

Closed
ppebb opened this issue May 29, 2024 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@ppebb
Copy link

ppebb commented May 29, 2024

Description of the Bug

Xnet controllers do not get the proper name of Gregtech machines connected to the network and do not have an image.
image

Reproduction

  1. Place a Gregtech machine
  2. Connect it with an xnet connector
  3. Place a controller on the same network
  4. Open the controller and you should see something similar to the above screenshot.

Version

0.1.12.7

Relevant log output

No response

@ppebb ppebb added the bug Something isn't working label May 29, 2024
@trainvoi
Copy link
Collaborator

known problem, unfortunately it's on xnet side

@chairclr
Copy link

Here's the offending line:
https://github.com/McJtyMods/XNet/blob/0ca5b08e451f4c9adce2ebafcb9767171a9ec67f/src/main/java/mcjty/xnet/modules/controller/client/GuiController.java#L601

Is it possible that Supersymmetry could use a fork of xnet with this fixed?

@loxoDev
Copy link
Collaborator

loxoDev commented May 29, 2024

We do have a fork, @ISurrealI is "managing" it. Maybe they could take a look.

@ppebb
Copy link
Author

ppebb commented Jun 3, 2024

Is this fork public? We were unable to find it on any associsted accounts or orgs. We'd like to go ahead and fix this at least for our own use even if we can't PR.

@trainvoi
Copy link
Collaborator

trainvoi commented Jun 7, 2024

Is this fork public? We were unable to find it on any associsted accounts or orgs. We'd like to go ahead and fix this at least for our own use even if we can't PR.

https://www.curseforge.com/minecraft/mc-mods/ynet-an-xnet-fork here's the link
and here's the repo
https://github.com/CaliforniaDemise/XNet-1.12

@MCTian-mi
Copy link
Collaborator

fixed in either one of the PRs you can see above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants