Default ORDER BY for all entities and their relationships #14685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
force-pushed
the
feature/order-by-id-by-default
branch
3 times, most recently
from
daf1db4 to
25b5c3c
Compare
GSadee
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
I am wondering whether this should be regarded as a bug fix or a new feature. In theory, this PR adds new functionality but also fixes an inconsistency in how data is loaded between different database engines, which fails some builds. I would probably be in favour of opening this to 1.11, but I'm curious to hear other people's opinions 🤔
|
What is more, if the base branch were to be changed (or not only then), it would be nice to note this change in the proper UPGRADE files. |
jakubtobiasz
approved these changes
Jan 10, 2023
coldic3
changed the title
probot-autolabeler
bot
added
the
Maintenance
coldic3
changed the title
coldic3
force-pushed
the
feature/order-by-id-by-default
branch
from
283c2f9 to
5ee52d0
Compare
coldic3
force-pushed
the
feature/order-by-id-by-default
branch
from
5ee52d0 to
2cffba8
Compare
coldic3
changed the title
coldic3
force-pushed
the
feature/order-by-id-by-default
branch
from
62e2c1e to
53caa2f
Compare
coldic3
changed the title
NoResponseMate
approved these changes
Jan 11, 2023
GSadee
approved these changes
Jan 12, 2023
|
Thanks, Kevin! 🥇 |
coldic3
added a commit
that referenced
this pull request
Jan 12, 2023
… all entities (GSadee) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12| | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no| | Related tickets | after #14685 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.11 or 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 3dbecb7 Add note to UPGRADE-1.12 file about default order by for all entities
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
OrderByIdentifierSqlWalkerand adds the defaultorder byto the ORM configurations for all relationships.