Template events system - replace topbar with newly introduced events #10991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Dec 27, 2019
pamil
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | related to #10924 |
| License | MIT |
pamil
added
the
Enhancement
pamil
changed the title
pamil
commented
Dec 27, 2019
| @@ -0,0 +1 @@ | |||
| {{ sonata_block_render_event('sylius.shop.layout.after_security_widget') }} | |||
There was a problem hiding this comment.
I'm thinking about the way to generalise these calls, creating a template for every legacy function call seems like an overkill.
pamil
changed the title
pamil
commented
Dec 27, 2019
| currency_switcher: | ||
| template: "@SyliusShop/Block/Layout/_currencySwitcher.html.twig" | ||
| locale_switcher: | ||
| template: "@SyliusShop/Block/Layout/_localeSwitcher.html.twig" |
There was a problem hiding this comment.
Need to figure out priorities for those blocks. Any ideas?
There was a problem hiding this comment.
I used the following conventions:
- last meaningful block starts at priority: 10
- other meaningful blocks are having a bigger priority than the last one by +10
- legacy Sonata events are +5 / -5 (before / after) from the related meaningful block
pamil
force-pushed
the
template-events/topbar
branch
from
fe39bc1
to
7e5abe8
Compare
pamil
changed the title
pamil
force-pushed
the
template-events/topbar
branch
from
7e5abe8
to
a9af307
Compare
12 tasks
lchrusciel
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.