Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest version no longer supports .NET Core 2.1 #111

Closed
coderpatros opened this issue Oct 27, 2020 · 3 comments · Fixed by #112
Closed

The latest version no longer supports .NET Core 2.1 #111

coderpatros opened this issue Oct 27, 2020 · 3 comments · Fixed by #112

Comments

@coderpatros
Copy link

Describe the bug
I'm using Snapshooter for some tests in a project that targets .NET Core 2.1 and 3.1. In the latest 0.5.7 release of Snapshooter.Xunit .NET Core 2.1 is no longer supported.

This change was made in Snapshooter for NUnit tests. (#110). The target framework was changed from netstandard2.0 to netstandard2.1 which isn't supported when targeting netcoreapp2.1.

It was probably an intentional change , but I wanted to check as it was just a patch version bump.

To Reproduce
Steps to reproduce the behavior:
Failing tests can be viewed here CycloneDX/cyclonedx-dotnet#247
You can also clone that repo locally if needed. dotnet test will run tests for 2.1 and 3.1. Although you need .NET Core 2.1 and 3.1 installed to run the tests. Although there is a devcontainer configuration. Repro by updating the Snapshooter.Xunit package references.

Expected behavior
Continued support for .NET standard 2.0 or major version bumps for breaking changes (with the caveat that right now this is still on 0.x.x versioning, so I can understand breaking changes coming in like this until a 1.0.0 release).

Desktop (please complete the following information):

  • OS: Linux
  • Version Ubuntu 20.04

Additional context
N/A

@RohrerF
Copy link
Member

RohrerF commented Oct 27, 2020

@coderpatros I agree with you that we keep support for netstandard2.0

@nscheibe
Copy link
Member

Yes, I agree as well. My mistake sorry.

@coderpatros
Copy link
Author

Thanks for the quick response @RohrerF and @nscheibe! I have no pressing need to move from the previous version. More than happy to wait for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants