Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add julia #84

Merged
merged 6 commits into from
Apr 3, 2020
Merged

feat: add julia #84

merged 6 commits into from
Apr 3, 2020

Conversation

rokroskar
Copy link
Member

Adds a julia 1.3.1 image.

@emmjab
Copy link
Contributor

emmjab commented Apr 3, 2020

I just made some changes to the image to match the changes that we made to similar images in the master branch in the mean time, to get it to build. I think it's good to merge!

Julia image tested here: https://dev.renku.ch/projects/e.jablonski/julia-docker-images-tests

@emmjab emmjab self-requested a review April 3, 2020 13:28
Copy link
Contributor

@emmjab emmjab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see former comment; I updated the image to match other changes, and tested it in the linked project!)

@rokroskar
Copy link
Member Author

Awesome, thanks @emmjab !

@rokroskar rokroskar merged commit 031fa69 into master Apr 3, 2020
@rokroskar rokroskar deleted the 000-add-julia branch April 3, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants