Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a bioconductor base #67

Merged
merged 21 commits into from
Feb 12, 2020
Merged

adding a bioconductor base #67

merged 21 commits into from
Feb 12, 2020

Conversation

emmjab
Copy link
Contributor

@emmjab emmjab commented Dec 12, 2019

an alternative to starting with the rocker docker image for R.

test from image built here: https://hub.docker.com/r/emmjab/r-bioconductor/tags
and project here: https://renkulab.io/projects/emma.jablonski/rbasic/files

@emmjab emmjab requested a review from cchoirat December 12, 2019 17:54
@rokroskar
Copy link
Member

What's the status here @emmjab and @cchoirat?

@cchoirat
Copy link

@emmjab, not sure how r-bioconductor gets created.

@emmjab
Copy link
Contributor Author

emmjab commented Jan 29, 2020

The idea from this was to use the bioconductor project as a base and add the renku dependencies on top, to share with the bioconductor community. I haven't looked at this in a while so i'll see if there were any bioconductor version updates and re-test.

@emmjab
Copy link
Contributor Author

emmjab commented Feb 10, 2020

The latest commits with the symlink & project opening for r projects (both the base and the bioconductor) "work", but also add in the project contents into the parent directory... need to fix this.


# install the jupyter stack
ARG JUPYTERHUB_VERSION=0.9.6
#RUN conda install --quiet --yes \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the commented pieces if they are not providing documentation?

rm -rf /home/$NB_USER/.cache/yarn && \
pip install -U --no-cache-dir pip wheel

#RUN pip install --no-cache-dir jupyter-rsession-proxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here - remove commented pieces

Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cleanup (see comments)

@rokroskar rokroskar merged commit 085b7e7 into master Feb 12, 2020
@emmjab emmjab deleted the bioc branch March 30, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants