Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bioc 3.16 and 3.17 to matrix #321

Merged
merged 4 commits into from
Mar 21, 2023
Merged

feat: add bioc 3.16 and 3.17 to matrix #321

merged 4 commits into from
Mar 21, 2023

Conversation

rokroskar
Copy link
Member

Adds bioconductor 3.16 to the build matrix.

@rokroskar rokroskar changed the title feat: add bioc 3.16 to matrix feat: add bioc 3.16 and 3.17 to matrix Mar 17, 2023
@olevski olevski self-requested a review March 21, 2023 13:47
@olevski
Copy link
Member

olevski commented Mar 21, 2023

@rokroskar I tested both the 3.16 and 3.17 bioconductor images. After the fix you added in the entrypoint (which we already merged) things work normally. So this can be merged.

@olevski olevski marked this pull request as ready for review March 21, 2023 14:54
@olevski
Copy link
Member

olevski commented Mar 21, 2023

If you merge this I will make a release.

@rokroskar
Copy link
Member Author

perfect, thank you!

@rokroskar rokroskar merged commit abcc3a3 into master Mar 21, 2023
@rokroskar rokroskar deleted the 000-add-bioc-3.16 branch March 21, 2023 14:55
@rokroskar
Copy link
Member Author

If you merge this I will make a release.

That would be great - I guess it can be 0.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants