fix: broken nbconvert package #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
p.s. the image from this PR is registry.dev.renku.ch/tasko.olevski/renku-images/renkulab-docker:0.0.1 Also here is the related issue on jupyter: jupyter/nbconvert#1742 |
rokroskar
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a lot of warnings in the console and making certain features of sessions buggy/unstable.
For example converting a notebook into anything would fail.
But also the notebooks and the jupyter server uses nbconver (for some reason) while it runs.
Example of failed client calls with our latest version:
Also failures such as this show up in the browser console:
With the update there are no such failed requests and the console has only warnings.
Here is a project that has the image from this PR pinned in its latest commit. In the first commit the older image that has issues is used.
There is an option to enable cypress to fail when there are any failures in the console. That would have caught this problem. I will enable it in a separate PR.