Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git client struggling with new letsencrypt root certificate #196

Closed
ableuler opened this issue Oct 25, 2021 · 3 comments · Fixed by #197
Closed

git client struggling with new letsencrypt root certificate #196

ableuler opened this issue Oct 25, 2021 · 3 comments · Fixed by #197
Labels
kind/bug Something isn't working

Comments

@ableuler
Copy link
Contributor

ableuler commented Oct 25, 2021

When trying to clone another renku project inside an interactive session through https, this currently fails with the following error:

$ git clone https://renkulab.io/gitlab/some.user/some-project.git
Cloning into 'some-project'...
fatal: unable to access 'https://renkulab.io/gitlab/some.user/some-project.git/': server certificate verification failed. CAfile: none CRLfile: none

While the new letsencrypt root certificate is present in the image under /etc/ssl/certs/ISRG_Root_X1.pem, the git https client does not find/respect/use that root certificate - presumably for some reasons about how git interacts with libcurl. Simply cURL-ing renkulab.io directly works.

However, upgrading cURL (and its dependencies) fixes the problem, so an easy way of fixing this for existing images is by adding the following lines to the projects Dockerfile:

USER root
RUN apt-get update && apt-get upgrade -y curl
USER ${NB_USER}

Later versions of the notebooks base image (such as jupyter/base-notebook:lab-3.2.1 or jupyter/base-notebook:lab-3.1.17) base image are built on top of ubuntu 20.04.03. These images do not suffer from this problem. The suggested proper fix for this issue is thus to upgrade to the jupyter/base-notebook:lab-3.2.1 base image.

--

ps: the reason why this isn't leading to catastrophic failures left and right is that the communication to the users "main" repo (the one from which the session is launched) is handled by the git-clone container and the git https proxy exclusively.

@ableuler ableuler added the kind/bug Something isn't working label Oct 25, 2021
@ableuler ableuler linked a pull request Oct 25, 2021 that will close this issue
@rokroskar
Copy link
Member

Has this been addressed somewhere @ableuler ?

@ableuler
Copy link
Contributor Author

#197

@rokroskar
Copy link
Member

😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants