feat: add acceptance tests #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The actions that build and push the images to renkus dockerhub I cancelled on purpose. I did not change those at all. |
rokroskar
reviewed
Jul 13, 2021
rokroskar
reviewed
Jul 15, 2021
rokroskar
reviewed
Jul 16, 2021
| path: /tmp | ||
| - name: Load Base Image in Docker | ||
| run: | | ||
| docker load --input /tmp/py.tar |
There was a problem hiding this comment.
this would never have occurred to me 👍
rokroskar
approved these changes
Jul 16, 2021
TaoSunVoyage
pushed a commit
that referenced
this pull request
Jul 22, 2021
* feat: add acceptance tests with cypress/mocha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds acceptance tests with cypress.
So far the tests only check that:
Other checks can be easily added - I did this just to test.
In addition we should add tests for the vnc image and for rstudio. I will reach out to Gavin about this.