Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add base image for batch execution #173

Merged
merged 4 commits into from
Aug 12, 2021
Merged

feat: add base image for batch execution #173

merged 4 commits into from
Aug 12, 2021

Conversation

TaoSunVoyage
Copy link
Contributor

@TaoSunVoyage TaoSunVoyage linked an issue Jul 7, 2021 that may be closed by this pull request
Add batch version image #172
Closed
@TaoSunVoyage TaoSunVoyage marked this pull request as ready for review July 22, 2021 15:16
rokroskar
rokroskar reviewed Jul 22, 2021
View reviewed changes
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance, but can you please rebase this branch on master so it's easier to see the new changes?

.github/workflows/acceptance_tests.yml Outdated
@@ -0,0 +1,64 @@
name: Acceptance tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rebase your branch on master...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Done.

@rokroskar
Copy link
Member

ahh much better  🙌

rokroskar
rokroskar reviewed Aug 12, 2021
View reviewed changes
docker/batch/Dockerfile

# inject entrypoint.sh
COPY --from=renku_base /entrypoint.sh /entrypoint.sh
ENTRYPOINT ["/entrypoint.sh"]
Copy link
Member

@rokroskar rokroskar Aug 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

rokroskar
rokroskar approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TaoSunVoyage TaoSunVoyage merged commit 141a832 into master Aug 12, 2021
@TaoSunVoyage TaoSunVoyage deleted the 172-batch-image branch August 12, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokroskar rokroskar rokroskar approved these changes

@gavin-k-lee gavin-k-lee Awaiting requested review from gavin-k-lee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add batch version image
2 participants
@TaoSunVoyage @rokroskar