Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding calcutta default fonts for vnc #167

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Conversation

gavin-k-lee
Copy link
Contributor

Fonts on the VNC have been updated to be consistent with the rest of the UI (Calcutta-Medium).

@gavin-k-lee
Copy link
Contributor Author

gavin-k-lee commented Jun 7, 2021

Tested on https://renkulab.io/projects/lee.gavin.k/renku-desktop/environments which fetches the image built on GH actions with the updates:

image

Checked with some symbols as well to confirm font:
image

@gavin-k-lee gavin-k-lee requested a review from ciyer June 7, 2021 10:41
@gavin-k-lee gavin-k-lee marked this pull request as ready for review June 7, 2021 12:48
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main content looks consistent with the UI now! 🎉

Could you
image

But the "Refresh your browser..." text is in a different font (Helvetica for me, something else for you). Could you set that to use Calcutta as well?

@gavin-k-lee
Copy link
Contributor Author

I believe that's fixed now (the same project was updated so you can view it there now)

image

ciyer
ciyer previously approved these changes Jun 7, 2021
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great now! Do you want to delete Calcutta-Medium.html now, or do you want to keep it around? I'm approving and leaving the decision on that file to you, Let me know if you need me to re-approve.

docker/vnc/fonts/calcutta/Calcutta-Medium.html Outdated Show resolved Hide resolved
@gavin-k-lee gavin-k-lee merged commit a3294af into master Jun 7, 2021
@gavin-k-lee gavin-k-lee deleted the 000-vnc-fonts branch June 7, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants