Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JupyterLab to 3.0.x #137

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Upgrade JupyterLab to 3.0.x #137

merged 3 commits into from
Jul 9, 2021

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jan 7, 2021

Fix #136

@rokroskar
Copy link
Member

Sorry @ciyer something got screwed up with rebases before - I rebased your commit on top of current master now. Note that what also needs to be done is to update the base image we use for our python image (i.e. jupyter/base-notebook) - we can probably go with the latest, but we will overwrite the installed jupyterhub (I believe it will be 1.3.0 in the base image but we're using 1.2.2 in the notebooks service so we should stay with that for now).

@rokroskar rokroskar marked this pull request as ready for review July 9, 2021 12:18
@rokroskar rokroskar requested a review from olevski July 9, 2021 13:00
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launched a quick session with the latest python image - everything seems in order. The error message from the logs about the resource usage meter is also gone.

@rokroskar rokroskar merged commit 274c0d4 into master Jul 9, 2021
@rokroskar rokroskar deleted the 136-jupyterlab-3 branch July 9, 2021 13:19
TaoSunVoyage pushed a commit that referenced this pull request Jul 22, 2021
Co-authored-by: Chandrasekhar Ramakrishnan <[email protected]>
Co-authored-by: Rok Roskar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to JupyterLab 3
4 participants