-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vscode to base image #134
Conversation
2894b71
to
5273b31
Compare
5273b31
to
c43683d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rokroskar I tested the image you mentioned. I did not go over all vs code features. But I did try launching vscode, making a new file and commiting and pushing it. That works. Also I tested out the terminal and running things - that was also fine.
I have only one comment though - should be easy to resolve.
34fe3df
to
1116ea5
Compare
@ciyer @olevski I removed the vscode install from the base
Of course the exact version of the file in the raw github link will be different, but this one works while this PR is open. See https://dev.renku.ch/projects/rokroskar/test-vscode/files/blob/Dockerfile |
1116ea5
to
c50af19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment. Everything else is fine. I tested the image created by adding the command you posted in the project's dockerfile. It works.
Adds VSCode using code-server and jupyter-vscode-proxy.
For testing, you can
use this image:add these lines to yourrenku/renkulab-py:3.7-c43683d
Dockerfile
:closes #83