Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscode to base image #134

Merged
merged 4 commits into from
Nov 26, 2020
Merged

feat: add vscode to base image #134

merged 4 commits into from
Nov 26, 2020

Conversation

rokroskar
Copy link
Member

@rokroskar rokroskar commented Nov 13, 2020

Adds VSCode using code-server and jupyter-vscode-proxy.

For testing, you can use this image: renku/renkulab-py:3.7-c43683d add these lines to your Dockerfile:

USER root
RUN curl -s https://raw.githubusercontent.com/SwissDataScienceCenter/renkulab-docker/c50af197ccd7b727b9baa0aebf60602c669ab546/scripts/install-vscode.sh | bash
USER ${NB_USER}

closes #83

@rokroskar rokroskar force-pushed the 83-add-vscode branch 2 times, most recently from 2894b71 to 5273b31 Compare November 14, 2020 00:27
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rokroskar I tested the image you mentioned. I did not go over all vs code features. But I did try launching vscode, making a new file and commiting and pushing it. That works. Also I tested out the terminal and running things - that was also fine.

I have only one comment though - should be easy to resolve.

docker/py/Dockerfile Outdated Show resolved Hide resolved
@rokroskar rokroskar force-pushed the 83-add-vscode branch 2 times, most recently from 34fe3df to 1116ea5 Compare November 25, 2020 14:15
@rokroskar
Copy link
Member Author

rokroskar commented Nov 25, 2020

@ciyer @olevski I removed the vscode install from the base Dockerfile and moved the steps to scripts/install-vscode.sh. I invoke it with these lines, and would add this to our base template but commented out:

USER root
RUN curl -s https://raw.githubusercontent.com/SwissDataScienceCenter/renkulab-docker/c50af197ccd7b727b9baa0aebf60602c669ab546/scripts/install-vscode.sh | bash
USER ${NB_USER}

Of course the exact version of the file in the raw github link will be different, but this one works while this PR is open. See https://dev.renku.ch/projects/rokroskar/test-vscode/files/blob/Dockerfile

@rokroskar rokroskar requested review from olevski and ciyer November 25, 2020 14:54
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Everything else is fine. I tested the image created by adding the command you posted in the project's dockerfile. It works.

docker/py/Dockerfile Outdated Show resolved Hide resolved
@olevski olevski self-requested a review November 26, 2020 10:27
@rokroskar rokroskar merged commit 5534f22 into master Nov 26, 2020
@rokroskar rokroskar deleted the 83-add-vscode branch November 26, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An image that supports VSCode
2 participants