Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: global git credentials and some other stuff #130

Merged
merged 2 commits into from
Oct 21, 2020
Merged

fix: global git credentials and some other stuff #130

merged 2 commits into from
Oct 21, 2020

Conversation

rokroskar
Copy link
Member

closes #128

@ableuler
Copy link
Contributor

Given the name of the PR I thought I'd have to greenlight a --global flag somewhere, and suddenly I find myself trying to verify the entrypoint logic of our R images... This is false advertisement here 😂

@rokroskar
Copy link
Member Author

Yeah I had to do that to not have the same git config copy-pasted in a few places... I thought it would just fly under the radar :)

@rokroskar
Copy link
Member Author

To be fair, I tried to be honest about it and split it into two commits. So it could in principle be separated if you want.

@rokroskar
Copy link
Member Author

Oh, this also closes #73 then...

@ableuler
Copy link
Contributor

ableuler commented Oct 16, 2020 •
edited
Loading

No worries, I'm on it!

@rokroskar rokroskar changed the title fix: global git credentials fix: global git credentials and some other stuff Oct 16, 2020
@rokroskar
Copy link
Member Author

I updated the title of the PR... 🥇

ableuler
ableuler approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@ableuler ableuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as it's supposed to. Left one comment for something that you could consider, but I'm fine with merging the PR as is.

@rokroskar rokroskar merged commit a1121ee into master Oct 21, 2020
@rokroskar rokroskar deleted the 128-global-git-credentials branch October 21, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ableuler ableuler ableuler approved these changes

@pameladelgado pameladelgado Awaiting requested review from pameladelgado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to clone private repos
2 participants
@rokroskar @ableuler