Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify use-cases which rely on a static Docker image #1611

Closed
3 of 6 tasks
ableuler opened this issue Oct 21, 2020 · 4 comments
Closed
3 of 6 tasks

Simplify use-cases which rely on a static Docker image #1611

ableuler opened this issue Oct 21, 2020 · 4 comments

Comments

@ableuler
Copy link
Contributor

ableuler commented Oct 21, 2020

Many RenkuLab use-cases (ie courses, tutorials) do not benefit from the fact that an image for an interactive environment is built for every commit. In contrary, (superfluous) image builds are oftentimes just slowing down the user experience, for example after forking a project. For these use cases we should make it possible to pin an image which is available in any registry and simply use that image for the interactive environments. The necessary steps could be:

  • The notebook service should allow clients to specify image to be used when the image for the specific commit is missing (see allow default image to be specified in server start request renku-notebooks#304).
  • The UI should read the default image from the project configuration and include it in the post request when the image is not availble (see Support custom registry images when starting a new interactive environment renku-ui#1105).
  • renku-python should allow to specify a default image for a project. This default image is added to the project configuration file.
  • renku-python should allow the specification of a pinned image for a project. If one is provided, the .gitlab-ci.ymlcan be omitted and the pinned image is added to the project configuration file.
  • The UI should include the additional project options for a default and a pinned image to the corresponding dialogue at project creation and potentially the project settings.
  • The UI should adapt the image launch dialogue and omit the red sign indicative for a failure when the project configuration contains a pinned image to use.
@lorenzo-cavazzi
Copy link
Member

I added a few issues to the epic.

I think point 4 or 5 should be handled with the project templates instead of adding any personalization to either renku-python or renku-ui. I'm not 100% sure I understand them correctly, but these are my thoughts:

  1. renku-python already allows specifying an image in the project config file, it should just be documented properly (Add documentation for pinning a registry image #1647 ). Omitting files should be part of specific templates. We may want to create a specific template as an example.
  2. Any extra variable required at project creation to specify an image should be specified in a project template and it's already supported in the UI. We could add Edit the project settings from the UI renku-ui#1114 to this epic (adjust settings from the UI) but I believe it's a generic UI improvement. Feel free to add it to this epic if you think it's especially important for the image.

@lorenzo-cavazzi
Copy link
Member

I believe this epic can be closed unless we prefer to include the issue about adjusting the project settings in the UI SwissDataScienceCenter/renku-ui#1114

@rokroskar
Copy link
Member

ping @ableuler - can we close this?

@ableuler
Copy link
Contributor Author

ableuler commented Feb 10, 2021

I'd say so, yes. The original intent is met and whatever comes up subsequently is probably best addressed under a new epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants