Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a single global model and adapt the old StateModel logic #627

Closed
3 tasks
lorenzo-cavazzi opened this issue Sep 24, 2019 · 0 comments · Fixed by #628
Closed
3 tasks

create a single global model and adapt the old StateModel logic #627

lorenzo-cavazzi opened this issue Sep 24, 2019 · 0 comments · Fixed by #628
Assignees
Milestone

Comments

@lorenzo-cavazzi
Copy link
Member

After discussing and trying a couple of solutions for addressing #623, it seems reasonable to do the following

  • create a single global model in the entry point src/index.js and pass it down to components requiring access to sub-models or to the redux store
  • move the sub-schema and re-factor the <component>Model as <component>Coordinator (start with notebooks as first example)
  • adapt the functions mapping the redux state to react properties
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Sep 24, 2019
@lorenzo-cavazzi lorenzo-cavazzi changed the title create a single global model and move there least a StateModel create a single global model and adapt the old StateModel logic Sep 24, 2019
@ciyer ciyer added this to the 0.7.0 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants