Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zenodo integration test #3625

Closed
Panaetius opened this issue Sep 27, 2023 · 1 comment
Closed

Fix Zenodo integration test #3625

Panaetius opened this issue Sep 27, 2023 · 1 comment
Assignees
Labels

Comments

@Panaetius
Copy link
Member

     @pytest.mark.integration
    @retry_failed
    @pytest.mark.vcr
    def test_dataset_export_upload_failure(runner, tmpdir, project, zenodo_sandbox):
        """Test failed uploading of a file to Zenodo deposit."""
        result = runner.invoke(cli, ["dataset", "create", "my-dataset"])
    
        assert 0 == result.exit_code, format_result_exception(result) + str(result.stderr_bytes)
        assert "OK" in result.output
    
        # create data file
        new_file = tmpdir.join("datafile.csv")
        new_file.write("1,2,3")
    
        # add data to dataset
        result = runner.invoke(cli, ["dataset", "add", "--copy", "my-dataset", str(new_file)])
        assert 0 == result.exit_code, format_result_exception(result) + str(result.stderr_bytes)
    
        result = runner.invoke(cli, ["dataset", "export", "my-dataset", "zenodo"])
    
        assert 1 == result.exit_code, result.output + str(result.stderr_bytes)
>       assert "metadata.creators.0.affiliation" in result.output
E       AssertionError: assert 'metadata.creators.0.affiliation' in ''
E        +  where '' = <RenkuResult KeyError('errors')>.output

This test has been failing in CI for a while, so it's unlikely that it's just due to Zenodo being flaky.

We should investigate this

@github-project-automation github-project-automation bot moved this to Backlog in renku-python Sep 27, 2023
@Panaetius Panaetius self-assigned this Oct 11, 2023
@Panaetius Panaetius moved this from Backlog to In Progress in renku-python Oct 11, 2023
@Panaetius
Copy link
Member Author

This doesn't happen anymore/was already fixed

@github-project-automation github-project-automation bot moved this from In Progress to Done in renku-python Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant