Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update template repo ref in renku-ui values #89

Open
ableuler opened this issue Sep 18, 2020 · 6 comments
Open

Automatically update template repo ref in renku-ui values #89

ableuler opened this issue Sep 18, 2020 · 6 comments
Labels
kind/enhancement New feature or request

Comments

@ableuler
Copy link
Contributor

Changes to master in this repo could automatically open a PR in the renku-ui repo to change the corresponding line in the values.yaml file of the UI chart. This would ensure that released versions of the ui chart use the up-to-date version of that repo. What do you think @SwissDataScienceCenter/renku-ui-maintainers?

@ableuler ableuler added the kind/enhancement New feature or request label Sep 18, 2020
@rokroskar
Copy link
Member

I think that value should be set in the main values file, since it's a deployment setting.

@rokroskar
Copy link
Member

The UI could optionally provide a maximum (minimum) template version that it supports/requires.

@ableuler
Copy link
Contributor Author

I think that value should be set in the main values file, since it's a deployment setting.

Makes sense. My point was mostly about about automatically using the head of this repo in our dev deploymentl. I guess we could automatically update the renku values if we want this, but maybe this repo is not changing frequently enough to justify the effort.

@rokroskar
Copy link
Member

I think our default should be master of the template repo. Then we don't have to update anything very frequently and we can just set the specific value when we do a release so it's stable when people deploy it.

@lorenzo-cavazzi
Copy link
Member

I believe the UI is now flexible enough to support a broad range of changes in the templates without requiring an update, so it makes sense to move this value setting somewhere else. The main values file seems a reasonable choice.

I think our default should be master of the template repo.

If you mean that master should be the default in renku-ui but always overwritten in 3rd pary RenkuLab deployment, I agree. (but this is not different now, we overwrite that value in all our deployments).
Otherwise, we would need to pay extreme care at possible breaking changes (even though they should be rare). Imagine a breaking change going in that would suddenly break all the RenkuLab deployments that are not up to date.
Another minor detail is that it's very easy to create identical projects, you just need to provide the same tag to the renku init command. If the target tag becomes master, that won't be trivial anymore.

@rokroskar
Copy link
Member

Sure, what I'm proposing is not any different than the default value in a development chart pointing to a "latest" image and then released charts pointing to a specific, pinned version. It's just that atm the value of the templates tag gets updated sporadically in the UI chart which makes things largely inconsistent. If there is, at some point, a reason to enforce a specific tag within a UI stream of development, we can of course pin it in the UI chart itself to be on the extra safe side.

@Panaetius Panaetius moved this to Backlog in renku-python May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants