-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically update template repo ref in renku-ui values #89
Comments
I think that value should be set in the main values file, since it's a deployment setting. |
The UI could optionally provide a maximum (minimum) template version that it supports/requires. |
Makes sense. My point was mostly about about automatically using the head of this repo in our dev deploymentl. I guess we could automatically update the renku values if we want this, but maybe this repo is not changing frequently enough to justify the effort. |
I think our default should be |
I believe the UI is now flexible enough to support a broad range of changes in the templates without requiring an update, so it makes sense to move this value setting somewhere else. The main values file seems a reasonable choice.
If you mean that |
Sure, what I'm proposing is not any different than the default value in a development chart pointing to a "latest" image and then released charts pointing to a specific, pinned version. It's just that atm the value of the templates tag gets updated sporadically in the UI chart which makes things largely inconsistent. If there is, at some point, a reason to enforce a specific tag within a UI stream of development, we can of course pin it in the UI chart itself to be on the extra safe side. |
Changes to master in this repo could automatically open a PR in the renku-ui repo to change the corresponding line in the values.yaml file of the UI chart. This would ensure that released versions of the ui chart use the up-to-date version of that repo. What do you think @SwissDataScienceCenter/renku-ui-maintainers?
The text was updated successfully, but these errors were encountered: