Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail on git submodule init #1466

Closed
olevski opened this issue Apr 26, 2023 · 1 comment · Fixed by #1472
Closed

Do not fail on git submodule init #1466

olevski opened this issue Apr 26, 2023 · 1 comment · Fixed by #1472
Assignees
@Panaetius
Labels
bug Something isn't working

Comments

@olevski
Copy link
Member

olevski commented Apr 26, 2023 •
edited
Loading

Currently when the repo is being cloned if there are git submodules and they are not setup properly the cloning will fail.

This should not be the case because many times git submodules are very easy to setup in a half-working or fully broken way.
@github-project-automation github-project-automation bot moved this to Backlog in renku-python Apr 26, 2023
@olevski olevski added the bug Something isn't working label Apr 26, 2023
@olevski olevski mentioned this issue Apr 26, 2023
Open
@olevski
Copy link
Member Author

olevski commented Apr 26, 2023

This is the exception in question:
https://github.com/SwissDataScienceCenter/renku-notebooks/blob/master/git_services/git_services/init/cloner.py#L170

@Panaetius Panaetius moved this from Backlog to Ready in renku-python Apr 28, 2023
@Panaetius Panaetius moved this from Ready to In Progress in renku-python Apr 28, 2023
@Panaetius Panaetius self-assigned this Apr 28, 2023
@Panaetius Panaetius mentioned this issue Apr 28, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in renku-python May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Panaetius Panaetius

Labels
bug Something isn't working
Projects
renku-python
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not fail on submodule errors SwissDataScienceCenter/renku-notebooks
2 participants
@Panaetius @olevski