Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH /session_launchers/<launcher_id> can silently discard invalid patches #627

Open
leafty opened this issue Feb 4, 2025 · 0 comments

Comments

@leafty
Copy link
Member

leafty commented Feb 4, 2025

In some cases, when performing PATCH /session_launchers/<launcher_id> with an invalid payload, the operation is marked as successful without raising a 422 validation error.

See:

def validate_session_launcher_patch(

The case patch.environment is not None and environment is None should be rejected as a validation error.

This issue could be fixed as part of #541.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant