Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a resource class is edited significantly the session may not resume #579

Open
olevski opened this issue Dec 17, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@olevski
Copy link
Member

olevski commented Dec 17, 2024

To replicate:

  • start a session using a resource class with a quota
  • hibernate the session
  • go to the admin panel and remove the quota
  • resume the session (it will not start)

This is because when we resume we do not check for the priority class assignment that comes from the quota.

In broader terms also I am not sure if we check whether the resource class that the session was started with still exists or not. And if the resource class does not exist then we should allow users to edit it / choose a different one.

@olevski olevski added the bug Something isn't working label Dec 17, 2024
@olevski
Copy link
Member Author

olevski commented Dec 17, 2024

This is potentially a 2 part fix/feature mix:

  • fix for changes to the priority class when resuming
  • feature / fix for gracefully handling missing resource classes when resuming

@olevski
Copy link
Member Author

olevski commented Dec 17, 2024

Found on renku version 0.61.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant