Provide migration guide #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
djbe
commented
May 17, 2017
•
djbe
commented
- Merge Filters with parameters #41 first
- Add link from changelog to migration guide
djbe
force-pushed
the
feature/migration-guide
branch
from
be37d76 to
76bcec9
Compare
AliSoftware
approved these changes
May 21, 2017
Documentation/MigrationGuide.md
Outdated
| with: | ||
| ```{{ myValue|snakeToCamelCase:true }}``` | ||
|
|
||
| ### For developers: |
There was a problem hiding this comment.
"### For developers using StencilSwiftKit as a Swift dependency" maybe? (Or if that makes the title too long, at least explain that in the first line/paragraph of that section)
Because most people using SwiftGen are writing code as a daily job and consider themselves as developers and might think that section applies to them 😉
There was a problem hiding this comment.
Hehe, I know 😆 I'll add that (without the Swift part, that should be clear enough), clarity is more important than nice titles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.