import tag for reusable macros

[cornr]

Implemented @nferruzzi node to import other Templates

[cornr]

I'm not sure with xcodeproj changes.
To bootstrap the project and run the tests I did swift package generate-xcodeproj

[djbe]

I don't think we've ever used swift package generate-xcodeproj. If you add files you should run pod install.

[djbe]

It might be better to undo the changes from swift package generate-xcodeproj, it seems to have added some unneeded files.

[cornr]

@djbe thanks for your help. I reverted the changes from swift package generate-xcodeproj and executed bundle exec pod install and now I am running into CocoaPods/CocoaPods#7708

Fixed with usage of cocoa pods 1.6 pre release

[nferruzzi]

thank you guys! I totally forgot about this <3

[cornr]

Sorry the PR is not working as expected. While I was testing the import Tag with Sourcery I figured that the loaded template is not populated to the context and therefore the macros are not visible.
@nferruzzi in your code snippet you call _ = try template.render(context) which is a non open function and therefore not visible in the ImportNode. The open template.render(context.flatten()) function uses a new context.
Any ideas to populate the new parsed tokens into the current context?

[nferruzzi]

sorry but I think I may not be of great help now, too many months since I created that node, but I keep using it daily and without any problem so it should be something minor; if I do remember properly the trick _ = .. was to avoid populating the output with the imported file output and template.render(context.flatten()) was to inject the context with the macro content.

My usage, is like this :

{% import "Label.swift.stencil" %}
{% import "Button.swift.stencil" %}
{% import "Activity.swift.stencil" %}

... from here I can {%call anyMacro %}

[nferruzzi]

Ok sorry my render function is a bit different now

    func render(_ context: Context) throws -> String {
        guard let templateName = try self.templateName.resolve(context) as? String else {
            throw TemplateSyntaxError("'\(self.templateName)' could not be resolved as a string")
        }

        let template = try context.environment.loadTemplate(name: templateName)

        _ = try template.render(context)
        return ""
    }

there is no flatten , maybe this helps

[djbe]

@cornr I've made a separate PR that updates cocoapods & swiftlint (#112), which has been merged. You should rebase this PR on master to get those changes.

Do note that if you run pod install, make sure to afterwards (in Xcode) select the Pods.xcodeproj and set the text indentation settings back to indent with spaces and 2:

This ensures everyone is writing with the same text editor settings.

[cornr]

@nferruzzi your code does not work with the current Stencil Release as its using a non open function: template.render(context)

@djbe I wonder why the usage of the include-tag does not work with macros?
I checked the code Include.swift and it looks pretty much the same as @nferruzzi implementation. Maybe the StencilSwiftKit tags are not registered in the used Environment.

[djbe]

The difference is subtle, but quite important:

• the include tag from Stencil surrounds the render call with a context.push(dictionary: subContext) {
• whereas this import tag does not

Surrounding the render with a context push causes all changes during that render (such as creating macro's, setting variables, etc…) to only be applied temporarily, and "popped" away when the render is done.

[djbe]

The current implementation was broken, because it was applying the changes to context.flatten(), which generates a dictionary copy. So the original context is not modified as it should be.

I've updated the implementation and written tests that actually test modification. The implementation currently does not compile, because it depends on the non-open function render which accepts a context. We'll need to modify Stencil to open this up first.