Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove join filter #10

Merged
merged 2 commits into from
May 16, 2017
Merged

remove join filter #10

merged 2 commits into from
May 16, 2017

Conversation

djbe
Copy link
Member

@djbe djbe commented Jan 16, 2017

No description provided.

@AliSoftware AliSoftware force-pushed the master branch 2 times, most recently from 9625443 to e9e33c6 Compare January 22, 2017 16:09
@AliSoftware AliSoftware force-pushed the feature/remove-join-filter branch from 48db3f1 to c5a2c8c Compare January 22, 2017 16:11
AliSoftware added a commit that referenced this pull request Jan 22, 2017
@AliSoftware
Add CHANGELOG entry for #10
c5a2c8c
@djbe
Copy link
Member Author

djbe commented Jan 27, 2017

let's not merge this until after we release swiftgen with great split implementation

@AliSoftware
Copy link
Contributor

I've tagged it with change: breaking to indicate that it should only be merged when we're ready for a major version bump. Let's finish the Great Split first and release a minor version including that new Great Split reorganisation first, and merge it afterwards for the next major where all templates and documentations would be updated and deprecated tags and filters will be completely removed.

@djbe djbe force-pushed the feature/remove-join-filter branch from c5a2c8c to 8b11db3 Compare January 28, 2017 14:50
djbe pushed a commit that referenced this pull request Jan 28, 2017
@AliSoftware @djbe
Add CHANGELOG entry for #10
8b11db3
@djbe djbe force-pushed the feature/remove-join-filter branch from 8b11db3 to 5fe9091 Compare January 28, 2017 21:37
djbe pushed a commit that referenced this pull request Jan 28, 2017
@AliSoftware @djbe
Add CHANGELOG entry for #10
5fe9091
@djbe djbe force-pushed the feature/remove-join-filter branch from 5fe9091 to b4fd20f Compare January 30, 2017 18:44
djbe pushed a commit that referenced this pull request Jan 30, 2017
@AliSoftware @djbe
Add CHANGELOG entry for #10
b4fd20f
@AliSoftware AliSoftware force-pushed the feature/remove-join-filter branch from b4fd20f to ecad8a2 Compare February 19, 2017 02:32
AliSoftware added a commit that referenced this pull request Feb 19, 2017
@AliSoftware
Add CHANGELOG entry for #10
ecad8a2
@djbe djbe added this to the 2.0.0 milestone Feb 20, 2017
@djbe djbe force-pushed the feature/remove-join-filter branch from ecad8a2 to e390ff0 Compare February 24, 2017 13:17
djbe pushed a commit that referenced this pull request Feb 24, 2017
@AliSoftware @djbe
Add CHANGELOG entry for #10
e390ff0
@djbe djbe force-pushed the feature/remove-join-filter branch from e390ff0 to 93fb972 Compare April 24, 2017 17:27
djbe pushed a commit that referenced this pull request Apr 24, 2017
@AliSoftware @djbe
Add CHANGELOG entry for #10
93fb972
@AliSoftware AliSoftware force-pushed the feature/remove-join-filter branch from 93fb972 to 81cb504 Compare May 1, 2017 20:01
AliSoftware added a commit that referenced this pull request May 1, 2017
@AliSoftware
Add CHANGELOG entry for #10
81cb504
@AliSoftware
Copy link
Contributor

Rebased and ready for the next major release

@djbe djbe force-pushed the feature/remove-join-filter branch from 81cb504 to 69d9d2e Compare May 16, 2017 11:36
djbe pushed a commit that referenced this pull request May 16, 2017
@AliSoftware @djbe
Add CHANGELOG entry for #10
69d9d2e
@djbe djbe force-pushed the feature/remove-join-filter branch from 69d9d2e to 9f20bef Compare May 16, 2017 11:54
@djbe djbe merged commit 21da18c into master May 16, 2017
@djbe djbe deleted the feature/remove-join-filter branch May 16, 2017 11:58
@djbe djbe mentioned this pull request May 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztofzablocki krzysztofzablocki krzysztofzablocki approved these changes

Assignees
No one assigned
Labels
change: breaking
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djbe @AliSoftware @krzysztofzablocki