Create new AlgorithmSignerWithAlgoName interface that will return the algorithm being signed with; use this to make publicKeyCallback work for custom signers. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwampDragons
changed the title
SwampDragons
changed the title
… during the ssh handshake. To accomplish this, we create a new "AlgorithmSignerWithAlgoName" interface that returns the custom algorithm being used for signing. This allows publicKeyCallback to handshake using the correct key algorihm in situations where key type != key algorithm. For example, ssh-rsa keys may need to handshake using the "rsa-sha2-256" algorithm if using a recent version of openssh that has deprecated the ssh-rsa sha1 algorithm. Fixes #39885
SwampDragons
force-pushed
the
fix_ssh_rsa_sha2_client
branch
from
ab67910 to
0bc1dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nnection