Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMPORTANT: the velocity loss had a bug! #10

Open
Svito-zar opened this issue Oct 5, 2020 · 0 comments
Open

IMPORTANT: the velocity loss had a bug! #10

Svito-zar opened this issue Oct 5, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Svito-zar
Copy link
Owner

The bug was fixed in this commit: 1164222 .

But this means that experiments with the velocity loss in the paper were not correct and should be disregarded.
@Svito-zar Svito-zar added the good first issue Good for newcomers label Oct 5, 2020
Svito-zar referenced this issue Oct 7, 2020
@Svito-zar
Fix a bug with the velocity loss
1164222 
It mixed up dimensions: since the first dimension was index in a batch but
not time, the loss was actually calculating the distance between two
sequences in a batch
@Svito-zar Svito-zar pinned this issue Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Svito-zar