Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the format of locale codes #111

Closed
Sv443 opened this issue Sep 27, 2024 · 0 comments · Fixed by #114
Closed

Change the format of locale codes #111

Sv443 opened this issue Sep 27, 2024 · 0 comments · Fixed by #114
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Sv443
Copy link
Owner

Sv443 commented Sep 27, 2024

idk why I didn't look this up before implementing it but the standard is to use a hyphen and not an underscore, eg. en-US and not en_US
This would remove all the criss-cross conversion bs I had to implement so the browsers would correctly understand the locale codes.

@Sv443 Sv443 added the enhancement New feature or request label Sep 27, 2024
@Sv443 Sv443 added this to the v2.2.0 milestone Sep 27, 2024
@Sv443 Sv443 self-assigned this Sep 27, 2024
@Sv443 Sv443 mentioned this issue Sep 27, 2024
46 tasks
@Sv443 Sv443 mentioned this issue Oct 8, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant