Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Save chapter as CBZ #33

Closed
Nonobis opened this issue Mar 13, 2021 · 18 comments · Fixed by #490
Closed

[Feature Request] Save chapter as CBZ #33

Nonobis opened this issue Mar 13, 2021 · 18 comments · Fixed by #490
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on

Comments

@Nonobis
Copy link

Nonobis commented Mar 13, 2021

What feature should be added to Tachidesk?

Explain What the feature is and how it should work in detail

Could you add an option save chapter as cbz ?

Why/Project's Benefit/Existing Problem

Explain why this should be added

Saving as CBZ will save place when downloading chaters

@Nonobis Nonobis added the enhancement New feature or request label Mar 13, 2021
@BradKML
Copy link

BradKML commented Mar 23, 2021

Question: What benefits does CBZ have over EPUB/MOBI/DJVU? Or is it merely a container and compression specification?
Another question: Would the image files contained in the CBZ be JPG/PNG or could it be something more advanced like JPEG-XL?

@Nonobis
Copy link
Author

Nonobis commented Mar 24, 2021

for me merely a container, png is good. I don't known jpeg-xl bug why not.

@AriaMoradi
Copy link
Member

AriaMoradi commented Mar 25, 2021

I don't have any plans to implement this feature, and it doesn't fit the intended design and usage, if you really want it, you have to come up with a PR first.

@AriaMoradi AriaMoradi added help wanted Extra attention is needed wontfix This will not be worked on labels Mar 25, 2021
@BradKML
Copy link

BradKML commented Mar 28, 2021

@AriaMoradi what if it is purely saving/caching manga tho? that is a default feature for Tachiyomi.

@AriaMoradi
Copy link
Member

@AriaMoradi what if it is purely saving/caching manga tho? that is a default feature for Tachiyomi.

Tachidesk already does that. It's in a directory called manga in the data directory.

@BradKML

This comment has been minimized.

@Robonau
Copy link
Contributor

Robonau commented Dec 24, 2021

its sad nothing came of this
cbz is a standard for pretty much every comic reader out there, the lack of support for usable formats makes the download button basically useless (what good is downloading if what you get isn't directly usable (adding EPUB/MOBI/PDF is probably also a good idea))

realistically this should be a vary simple add since a cbz is just a renamed zip
each chapter being its own cbz

@AriaMoradi
Copy link
Member

Tachidesk (and Tachiyomi) save chapter images in a plain image format, in the format the source provides them, it's essentially a local/saved/snapshot/cache of the source, saving it in cbz doesn't make sense. the images are usually highly compressed, why compress them again?

If it's for easier viewing, you should use the client's provided image viewer, it's what the app does after all.
If you need the saving az cbz for archiving proposes, then use one of the many manga downloaders out there like FMD2

@AriaMoradi
Copy link
Member

AriaMoradi commented Dec 25, 2021

Tachiyomi might get the feature, look at https://github.com/tachiyomiorg/tachiyomi/pull/6360
If it does, I'll consider porting their solution.

@Robonau
Copy link
Contributor

Robonau commented Jan 7, 2022

Tachidesk (and Tachiyomi) save chapter images in a plain image format, in the format the source provides them, it's essentially a local/saved/snapshot/cache of the source, saving it in cbz doesn't make sense. the images are usually highly compressed, why compress them again?

If it's for easier viewing, you should use the client's provided image viewer, it's what the app does after all. If you need the saving az cbz for archiving proposes, then use one of the many manga downloaders out there like FMD2

a zip/cbz is lossless so nothing is lost in the compression

for me at least the client is missing features that are available with other readers (mainly tracking, komga + malsync (i have suggested malsync add support for tachidesk))

keeping a list manually updated in multiple places is rather inconvenient (not to mention lack of linux support for fmd2)
note:i already have a script to automatically download new chapters in my library (slimier to tachiyomis option to download new chapters (i like having backups)) (running in nodejs along side the tachidesk instance)

note2: the PR seems to have been merged

@AlyafeiAli

This comment was marked as spam.

@gregorybeal

This comment was marked as spam.

@lennie420

This comment was marked as spam.

@Theangelofspace15
Copy link

Tachiyomi might get the feature, look at tachiyomiorg/tachiyomi#6360 If it does, I'll consider porting their solution.

Now that tachiyomi has the option, can we get the option to save as cbz? I also like saving and reading from cbz.let me organize everything by MANGA/CHAPTERS.cbz and the format is pretty much use by all the clients I used.

@fatotak
Copy link

fatotak commented Dec 5, 2022

I'd love to see this implemented.

In addition to this, I'd like to suggest either of the following (when this option is enabled):

  1. Download images to RAM, and then only save to disk the CBZ. (single write works better than write, write, write, compress delete on multiple file systems including slow disks, SSDs (for wear durability), ZFS, and so on)/
  2. Alternatively, allow users to configure a scratch location to download to (i.e., in my case, I'd configure scratch as a mdadm raid 0 tmp vol, and perm download as a zfs pool), and then move the file to the permanent location when compressing.

Right now, I have to set my tachidesk DL location to the scratch disk, and then run a custom script to zip them up and move them to my zfs pool every so often.

@HongYue1
Copy link

HongYue1 commented Jan 6, 2023

I also support this feature, I have no problem with PNG myself, but when my manga library reached 250K+ images, it made the thought of moving it to another place a nightmare.

@AngelaDMerkel
Copy link

AngelaDMerkel commented Jan 15, 2023

I sync my tachidesk library to drive using rclone and having CBZ would improve performance significantly. Uploading and indexing (literally) 100s of thousands of files is rather slow when compared to the speed that can be accomplished with fewer, but larger, files. If tachidesk were to implement this it would also allow using the docker rclone volume plugin and therefore reading and writing directly to a mount. This would be very useful.

Re @fatotak suggestion:

Download images to RAM, and then only save to disk the CBZ. (single write works better than write, write, write, compress delete on multiple file systems including slow disks, SSDs (for wear durability), ZFS, and so on)/

Having a scratch location would be more ideal for systems pressed for memory. I run tachidesk on an rPi to minimise power consumption, alongside a few always on services. Parallel downloads like Tachiyomi has in addition to writing to ram could be a concern on lower memory systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.