Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Custom regex on extension doesn't work #1215

Open
kana-shii opened this issue Dec 27, 2024 · 0 comments
Open

[Bug] Custom regex on extension doesn't work #1215

kana-shii opened this issue Dec 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kana-shii
Copy link

kana-shii commented Dec 27, 2024

Device information

  • Suwayomi-Server version: v1.1.1-r1650
  • Server Operating System: Windows 11
  • Server Desktop Environment: N/A
  • Server JVM version: Java 21
  • Client Operating System: Windows 11
  • Client Web Browser: Opera GX

Steps to reproduce

  1. Get an extension with a customizable title regex (will provide here together with the source code)
  2. Try using a custom regex in the extension. My regex: (?:\([^()]*\)|\{[^{}]*\}|\[(?:(?!]).)*]|«[^»]*»|〘[^〙]*〙|「[^」]*」|『[^』]*』|≪[^≫]*≫|﹛[^﹜]*﹜|〖[^〖〗]*〗|𖤍.+?𖤍|《[^》]*》|⌜.+?⌝|⟨[^⟩]*⟩|\/official|\/ official|【[^】]*】) (the newly added part is the 【[^】]*】 pattern. You can see the regex doing nothing in the entry: Press Play, Sami【YesungWaifu】and you can see the regex working in the entry: Who Made Me a Princess (Official)

Expected behavior

The regex should work and unnecessary stuff from the title should be removed

Actual behavior

The newly-added patterns don't work

Other details

https://github.com/komikku-app/komikku-extensions/commit/0951e9e6d966238caa431ef057d019bf08d5bd3b (this is the code for the extension
Can't upload the file for the .apk over in github but you guys can @ me in the Suwayomi server for the .apk if needed
just @s_selfish
Fyi: The custom regex always worked out over Mihon. Also, the default regex of the extension works out, but not the custom one.

@kana-shii kana-shii added the bug Something isn't working label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant