You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1800: I'm going to simplify the tests we have so far, so the CSV content is stored within files in the test/files directory. That way, we have a bunch of fake files to use, rather than the content being supplied directly in the unit tests and most importantly, these files can be uploaded into the web interface by the Behat tests.
The new Statement object will have a clear() function that will delete all of the contained Uploads, which means the UploadManager or Upload needs a delete() function. Implementing this test now...
1900: Functionality is complete, now to test it in a web browser.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
1h development @g105b
1800: I'm going to simplify the tests we have so far, so the CSV content is stored within files in the
test/files
directory. That way, we have a bunch of fake files to use, rather than the content being supplied directly in the unit tests and most importantly, these files can be uploaded into the web interface by the Behat tests.Here's an example CSV file with the bare minimum for testing: https://github.com/SuperHyperInstantFutureTime/Trackshift/blob/658e366cb6a13f94b659b42ef117a2e1f23c764e/test/files/prs-simple-3-songs.csv
And the updated unit tests pass: https://github.com/SuperHyperInstantFutureTime/Trackshift/actions/runs/3430639551
1810: The first Behat scripts need to be added to the repository, for testing anonymous usage in the browser...
Here is the first Behat test: https://github.com/SuperHyperInstantFutureTime/Trackshift/blob/fb79fda92e4860090043df78dfad59f828c3cf26/test/behat/features/anonymous-user.feature - it can be run locally, but I need to look at how to get Behat running within our Github Actions test runs. I'll take a look at that next week.
For now, I need to actually add some value: I'm going to make it add multiple PRS statements. Here's a checklist:
UploadManager
'sload()
function can take more than one file path, and the result is aStatement
object that contains zero or moreUpload
objects: https://github.com/SuperHyperInstantFutureTime/Trackshift/blob/97899a7f254ab31cf31e79b491b8768dd22d5d5d/test/phpunit/Upload/UploadManagerTest.php#L30-L42The new
Statement
object will have aclear()
function that will delete all of the contained Uploads, which means theUploadManager
orUpload
needs adelete()
function. Implementing this test now...1900: Functionality is complete, now to test it in a web browser.
Here's the first new Behat test
1905: Here's the implementation
1910: Here's the end-test for the latest feature
And a sign-off screen recording of it in action:
Beta Was this translation helpful? Give feedback.
All reactions