New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First parameter of search $client->search->query should clearly accept `FilterQuery` #4

Open

g105b opened this issue Dec 8, 2023 · 0 comments

Labels

Contributor

g105b commented Dec 8, 2023

At the moment, it just accepts a string, but FilterQuery is Stringable... but there's no way for the developer to know that.

public function query(
	FilterQuery|string $query,  // much better for self-documentation
	SearchFilter $searchType,
	?string $market = null,
	int $limit = 20,
	int $offset = 0,
	?string $includeExternal = null,
):SearchResult

The text was updated successfully, but these errors were encountered:

g105b added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment