Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference data for entangled units "dimer" test on Julia 1.11 #326

Merged
merged 15 commits into from
Nov 1, 2024
Merged

Fix reference data for entangled units "dimer" test on Julia 1.11 #326

merged 15 commits into from
Nov 1, 2024

Conversation

kbarros
Copy link
Member

@kbarros kbarros commented Oct 30, 2024

No description provided.

@kbarros kbarros requested a review from ddahlbom October 30, 2024 20:33
ddahlbom
ddahlbom approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@ddahlbom ddahlbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. (I would have been happy to. I should've opened something earlier.)

This looks good to me. I see the same numbers on my end for 1.11. I added a few @test annotations that I had forgotten.

@kbarros kbarros merged commit 07a25f7 into main Nov 1, 2024
4 checks passed
@kbarros kbarros deleted the fix-ref branch November 1, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddahlbom ddahlbom ddahlbom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbarros @ddahlbom