Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation in absolute units #171

Open
ddahlbom opened this issue Sep 22, 2023 · 0 comments
Open

Interpolation in absolute units #171

ddahlbom opened this issue Sep 22, 2023 · 0 comments

Comments

@ddahlbom
Copy link
Member

ddahlbom commented Sep 22, 2023

When retrieving intensities from classical structure factors, rounding to nearest available wave vector currently takes place in "RLU space." This is in some sense incorrect, and the rounding should instead be done in the global coordinate system.

Probably the most appropriate way to "round" would be to perform a Voronoi decomposition of the sample points as they are distributed in the global frame. Since we are dealing with a regular lattice, this decomposition can probably be precomputed in some way (rather than performing a local search to make a local Voronoi decomposition).

The issue is then: perform this "Voronoi rounding" in a fast and general way or implement an appropriate heuristic that approximates this type of rounding.

EDIT: Additionally, even with the Voronoi decomposition, we'll frequently encounter edge cases which should be dealt with in a satisfactory way. For example, in the attached image, the choice of wave vector is ambiguous when the path (red line) runs directly on top of the cell boundary for some finite length.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant