From d7306889f3eede4e34c6aa3317ea040d86627bd7 Mon Sep 17 00:00:00 2001 From: Kartheek Palla Date: Wed, 18 Dec 2019 21:27:19 +0530 Subject: [PATCH 1/4] Issue #SB-16429 fix: updated test coverage cmd --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index d6404bb9..d23d4494 100644 --- a/package.json +++ b/package.json @@ -127,7 +127,7 @@ "testpluginframework": "karma start karmaconf.pluginframework.js", "build-npm-pkg": "gulp packageCorePlugins && npm run build-plugins && npm run build-editor && cd content-editor && gulp minifyJs && gulp copystyleImages && gulp clean && gulp injectrenamedfiles", "test": "karma start karmaconf.js && karma start karmaconf.pluginframework.js", - "test-with-coverage": "istanbul cover karma start karmaconf.pluginframework.js && cat ./coverage/lcov.info" + "test-with-coverage": "istanbul cover karma start karmaconf.pluginframework.js && istanbul cover karma start karmaconf.js" }, "repository": { "type": "git", From 438349d7996191b6046e8c0c861f02f51db06080 Mon Sep 17 00:00:00 2001 From: Kartheek Palla Date: Wed, 18 Dec 2019 21:44:59 +0530 Subject: [PATCH 2/4] Issue #SB-16429 feat: sonarqube changes --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3ab3fff5..4220f1bb 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -43,7 +43,7 @@ jobs: - run: name: test-with-coverage - command: 'npm run test-with-coverage' + command: 'npm run test' - run: mkdir -p /tmp/coverage && cp ./coverage/lcov.info /tmp/coverage From 643a624d4f4a8504fad77e2dbf7db31656fed89b Mon Sep 17 00:00:00 2001 From: Kartheek Palla Date: Wed, 18 Dec 2019 22:01:17 +0530 Subject: [PATCH 3/4] Issue #SB-16429 fix: sonarqube changes --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4220f1bb..a3722c14 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -45,7 +45,7 @@ jobs: name: test-with-coverage command: 'npm run test' - - run: mkdir -p /tmp/coverage && cp ./coverage/lcov.info /tmp/coverage + - run: mkdir -p /tmp/coverage && cp /root/content-editor/coverage_framework/lcov/HeadlessChrome 78.0.3904 (Mac OS X 10.12.6)/lcov.info /tmp/coverage - run: name: Install sonar scanner From c5e887745dbe83823c6a7e715f929ba7ddb7b86f Mon Sep 17 00:00:00 2001 From: Kartheek Palla Date: Wed, 18 Dec 2019 22:32:43 +0530 Subject: [PATCH 4/4] Issue #SB-16429 fix: lcov path issue fixed --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index a3722c14..b585f1a1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -45,7 +45,7 @@ jobs: name: test-with-coverage command: 'npm run test' - - run: mkdir -p /tmp/coverage && cp /root/content-editor/coverage_framework/lcov/HeadlessChrome 78.0.3904 (Mac OS X 10.12.6)/lcov.info /tmp/coverage + - run: mkdir -p /tmp/coverage && cp /home/circleci/content-editor/coverage_framework/lcov/HeadlessChrome\ 59.0.3071\ \(Linux\ 0.0.0\)/lcov.info /tmp/coverage - run: name: Install sonar scanner