Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rsh = -dV/dI @ Isc constraint in gen_coeffs #90

Open
mikofski opened this issue Sep 22, 2018 · 0 comments
Open

Remove rsh = -dV/dI @ Isc constraint in gen_coeffs #90

mikofski opened this issue Sep 22, 2018 · 0 comments

Comments

@mikofski
Copy link
Contributor

mikofski commented Sep 22, 2018

I have used this constraint successfully for years, but it's time to let this go

  1. It is too restrictive. It fits well SunPower modules, but not other modules and also not other irradiance conditions
  2. Other fitting algorithms do not use it although some do, maybe in the docs or wiki we can do a review. SAM does not use this constraint, instead they use the point at short circuit
  3. There is only weak theoretical bases for this constraint, but mostly, it's inconsistent with how we generate IV curves - should the fitting procedure just be the opposite of the calculation?

I propose we follow SAM and just use these four

  1. Point at short circuit
  2. Point at open circuit
  3. Point at mpp
  4. slope at mpp of power-current cure should be zero

We already use 2, 3, and 4, and adding 1 is trivial, it's actually already in the because it's use to calculate Igen (aka Iph or also IL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant