Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with <ruby> tag #199

Closed
Sub6Resources opened this issue Dec 14, 2019 · 2 comments
Closed

Fix issues with <ruby> tag #199

Sub6Resources opened this issue Dec 14, 2019 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Sub6Resources
Copy link
Owner

#178 added support for the <ruby> element, but there are a couple small issues with text scaling and line height when using the <ruby> element. These issues mostly stem from using the Transform widget, which can draw outside of its parent's boundaries.

@Sub6Resources Sub6Resources added bug Something isn't working 1.0.0 labels Dec 14, 2019
@Sub6Resources Sub6Resources added this to the 1.0.0 milestone Dec 14, 2019
@Sub6Resources Sub6Resources self-assigned this Dec 14, 2019
@JeskTop
Copy link
Contributor

JeskTop commented Mar 3, 2020

Style could not work for <ruby> and <rt>. This is another problem.

style: {
  "ruby": Style(
      color: Colors.red,
      fontSize: FontSize(18.0)
  )
}

@Sub6Resources
Copy link
Owner Author

Thank you @JeskTop. We'll work to resolve those issues as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants