Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend OnLinkTap function with link label #164

Closed
DagobertDokate opened this issue Sep 26, 2019 · 3 comments
Closed

Extend OnLinkTap function with link label #164

DagobertDokate opened this issue Sep 26, 2019 · 3 comments

Comments

@DagobertDokate
Copy link

We would have liked to have extended the OnLinkTap function so that it also outputs the name of the link. This allows a tracking to be built in, which name the user clicks on.

What do you think of this extension?

@DagobertDokate DagobertDokate changed the title OnLinkTap function Extend OnLinkTap function with link label Sep 26, 2019
@DagobertDokate
Copy link
Author

Any news for me?

@Sub6Resources
Copy link
Owner

This would be a breaking change, so I'm hesitant to introduce it when the vast majority of users don't require this use case. Can you give a bit more info on your use case for sending the name of the link along with the url? If you want to do tracking couldn't you just add some sort of query parameter to the url?

@ryan-berger
Copy link
Collaborator

@DagobertDokate Please take a look at #301 and read through it, as it is a similar use case that could be bringing a proposal to the table that would help you both. Please take a look and feel free to comment over on the other issue to help in building out the proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants