Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Direction based Border and EdgeInsets for RTL #1042

Open
YoofiBP opened this issue Apr 14, 2022 · 2 comments
Open

Support Direction based Border and EdgeInsets for RTL #1042

YoofiBP opened this issue Apr 14, 2022 · 2 comments
Assignees
@Sub6Resources
Labels
css Enhancements/issues with css properties enhancement New feature or request layout Issues related to our layout algorithm rtl-text Issues with text rendered in rtl mode
Milestone
Priority Goals

Comments

@YoofiBP
Copy link

YoofiBP commented Apr 14, 2022 •
edited
Loading

Describe your feature request

The Style widget currently supports the Border and EdgeInsets class for borders, padding, margins etc. However this is oriented towards LRT text. We cannot use BorderDirectional and EdgeInsetsDirectional to support RTL instances. The package should support using these.

Additional context

A picture of a cute animal (not mandatory but encouraged)
@YoofiBP YoofiBP added the enhancement New feature or request label Apr 14, 2022
@YoofiBP YoofiBP changed the title [FEATURE] Support Direction based Border and EdgeInsets for RTL Apr 14, 2022
@erickok
Copy link
Collaborator

erickok commented May 24, 2022

I'm gonna be honest and say that I have little tono experience with RTL text on Flutter, but I absolutely agree that we should cater as much as possible for this. Could you help us by giving some pointers on the things we should change?

@Sub6Resources Sub6Resources added the css Enhancements/issues with css properties label Jun 10, 2022
@Sub6Resources
Copy link
Owner

#1270 starts to address this. I wonder if we can add some interfacing between our HtmlPaddings and EdgeInsetsDirectional. I'll look into this.

@Sub6Resources Sub6Resources added this to the 3.0.0 milestone May 17, 2023
@Sub6Resources Sub6Resources added rtl-text Issues with text rendered in rtl mode layout Issues related to our layout algorithm labels May 17, 2023
@Sub6Resources Sub6Resources self-assigned this May 17, 2023
@Sub6Resources Sub6Resources modified the milestones: 3.0.0, Priority Goals May 23, 2023
@Sub6Resources Sub6Resources moved this to Todo in flutter_html Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sub6Resources Sub6Resources

Labels
css Enhancements/issues with css properties enhancement New feature or request layout Issues related to our layout algorithm rtl-text Issues with text rendered in rtl mode
Projects
flutter_html
Status: Todo
Milestone
Priority Goals
Development

No branches or pull requests
3 participants
@erickok @Sub6Resources @YoofiBP