Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected text barely visible (White highlight) #834

Closed
956MB opened this issue Jan 17, 2019 · 3 comments
Closed

Selected text barely visible (White highlight) #834

956MB opened this issue Jan 17, 2019 · 3 comments

Comments

@956MB
Copy link

956MB commented Jan 17, 2019

Highlighting both code and regular text is changing the color of the text to white and not having the light blue background behind to easily tell what you're selecting. On some code/text it looks and works fine, but on some other specific pages, it is quite hard to tell what you're selecting on that page with it being white. I don't know if this was a universal Github Dark change or not, but Im just wondering where I can look to possibly edit this, because I don't know. If I got something wrong or this issue has been addressed and changed, I apologize. Ive looked around for a solution and haven't seen it. :)
  • Browser: Safari 12.0.2 / Chrome 71.0.3578.98

  • Operating System: macOS Mojave 10.14.2

  • Screenshot:
    ezgif com-video-to-gif-2

Steps using Stylus on macOS/Windows in Chrome:

1. Click "Install the usercss" from Github Dark README.md:

799976c58c6b43aa5063e7921bbaf1a6

2. Click "Install style" from Stylus page that pops up:

download 20

3 "Github Dark" theme is set. Open Github in Chrome and highlight text.

Steps using Cascadea app on macOS in Safari:

1. Click "Install the usercss" from Github Dark README.md:

799976c58c6b43aa5063e7921bbaf1a6

2. Click "Allow" on popup to open in Cascadea.app:

5eee91b21cbdf4618afc97c206b3fdf3

3. Click 'Yes' when asked "Do you want to install the style "GitHub Dark"?"

4. "Github Dark" theme is set. Open Github in Safari and highlight text.

@the-j0k3r
Copy link
Member

Hello and thank you for the report.

Please read #808 (comment)
and
#808 (comment)

Those should let you know about the limitations of cascadea and what you can do.

@silverwind
Copy link
Member

Hmm, but it should not happen with Stylus and Chrome.

@956MB
Copy link
Author

956MB commented Jan 22, 2019

1. Change "text selection" color values on line 1315 from default: #fff (White), and add background-color on line 1314:

screen shot 2019-01-22 at 1 27 22 am

@956MB 956MB closed this as completed Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants