Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed player instance deprecating. #90

Merged
merged 1 commit into from
Aug 21, 2015
Merged

Fixed player instance deprecating. #90

merged 1 commit into from
Aug 21, 2015

Conversation

az33zy
Copy link
Contributor

@az33zy az33zy commented Aug 20, 2015

Deactivating an audio session that has running I/O. All I/O should be stopped or paused prior to deactivating the audio session.

Deactivating an audio session that has running I/O. All I/O should be stopped or paused prior to deactivating the audio session.
@saiday
Copy link
Member

saiday commented Aug 20, 2015

Hi @cybitzix, after you set AVAudioSession's category to nil, what would category property would be if you access it by [[AVAudioSession sharedInstance] category]?

@az33zy
Copy link
Contributor Author

az33zy commented Aug 20, 2015

Hi. Do I need accessing category property after I deprecate the instance?

@saiday
Copy link
Member

saiday commented Aug 20, 2015

No no, I am wondering about setting category to nil, from Apple's document I don't see category can be set to nil, so just a little curious what will category be after set to nil.

@az33zy
Copy link
Contributor Author

az33zy commented Aug 20, 2015

I had an error with deprecating player instance in iOS 8 and found a solution. To completely stop I/O in an audio session we need to set the category property to nil.

saiday added a commit that referenced this pull request Aug 21, 2015
Fixed player instance deprecating.
@saiday saiday merged commit 88492ef into StreetVoice:master Aug 21, 2015
@sgtsquiggs
Copy link

This is causing an error in iOS9

- (BOOL)setCategory:(NSString * nonnull)theCategory error:(NSError * nullable * nullable)outError

Category shouldn't be set to 'nil'.

saiday added a commit that referenced this pull request Aug 29, 2015
@saiday
Copy link
Member

saiday commented Aug 29, 2015

@sgtsquiggs thank you for reporting this issue, reverting this pull request.
@cybitzix FYI.

@saiday
Copy link
Member

saiday commented Aug 29, 2015

@cybitzix I run HysteriaPlayer on iOS 8 as well, I have no errors when deprecating. Can you paste the error you got here, so we can tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants