Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry for debugging purposes #68

Open
Strajk opened this issue Jun 19, 2020 · 2 comments
Open

Telemetry for debugging purposes #68

Strajk opened this issue Jun 19, 2020 · 2 comments

Comments

@Strajk
Copy link
Owner

Strajk commented Jun 19, 2020

Hi, while checking the codebase, I've found a lot of features that are probably not needed anymore due to changes on Strava website.

But I'm a little worried about the word probably :)

Strava websites change a lot – both by developing new features, but also by various experiments/ab-testing/region-based new feature rollout/conditions for premium/non-premium users. So, it's very hard to test the extension thoroughly.

What do you think about adding telemetry for debugging/dev purposes?
Definitely anonymous, available as an option, and off by default.


Very basic example use case

  • There's hide_upcoming feature
  • I'm 99%, maybe 90%, maybe 85%, sure that it's not needed anymore
  • But, before removing it, I would like to check if it's really not used
  • We would add telemetry to it
  • If there would be no data about it for a – let's say – month, then we can remove it
// Before removing upcoming-events feature
$.option('meta:telemetry', function() {
  if ($('.sidebar .section#upcoming-events').length) {
    LOG('Upcoming events element found')
  }
});

What do you think about this? @lamby
I'm not sure about specific implementation details right now, wanna discuss it before thinking about it further.

@lamby
Copy link
Collaborator

lamby commented Jun 19, 2020

Hm, good idea but on careful reflection, I think this might be overdoing things — I don't really want to watch/maintain telemetry data to work around Strava even more, if you know what I mean.

@Strajk
Copy link
Owner Author

Strajk commented Jun 20, 2020

@lamby after some time to think about it more, I agree. Let's keep it simple for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants