Fix accelsearch #807
Merged
Fix accelsearch #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #807 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 45 45
Lines 8988 8989 +1
=======================================
+ Hits 8666 8667 +1
Misses 322 322 ☔ View full report in Codecov by Sentry. |
mgullik
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Hey @matteobachetti, I'm not an expert about this, but it looks like an easy fix.
My only concern is that I don't see any additional test or changes in the current version of the tests. Is it correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accelsearch, empty intervals are approximated with the mean of the data. If the estimate of nphots was done after this, nphots became unreasonably high, leading to very low values of power
This simple fix restores a decent calculations of nphots