-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminated the usage of astropy logging #799
Eliminated the usage of astropy logging #799
Conversation
@matteobachetti Kindly review this PR. |
@kr-2003 could you post a screenshot of the new logger in action? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
==========================================
- Coverage 96.35% 94.37% -1.98%
==========================================
Files 43 44 +1
Lines 8784 8824 +40
==========================================
- Hits 8464 8328 -136
- Misses 320 496 +176 ☔ View full report in Codecov by Sentry. |
@matteobachetti Most of the changes were related to |
@kr-2003 thanks for your contribution! Please note that there are tests failing related to the absence of a changelog (in |
@matteobachetti I passed the tests related to |
Actually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The failures and the lack of coverage are independent on this PR. Thanks @kr-2003 !
d47c95b
Encapsulated the logging setup in a function in a separate file(loggingconfig.py), then called this function from different files where logging is needed.